[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [57023] trunk/blender/source/blender/ editors/space_view3d/drawobject.c: Simple usability fix:

[Ton Roosendaal]

Hi,

For me it shows in both in wire as in solid quite clear, just a bit subtle.

The main thing is to have a clear difference between active+selection. Some variations here are easily possible. The theme color currently is only used for active + not selected.

Here's what I see in default theme.

Solid:
http://www.pasteall.org/pic/52152

Wire:
http://www.pasteall.org/pic/52153

The stippling is also a bit ugly, could be looked at ditching it in favour of blending color like for other transparent selected overlay faces.

-Ton-

--------------------------------------------------------
Ton Roosendaal  -  ton at blender.org   -   www.blender.org
Chairman Blender Foundation - Producer Blender Institute
Entrepotdok 57A  -  1018AD Amsterdam  -  The Netherlands



On 25 May, 2013, at 20:48, Campbell Barton wrote:

> Dont think this change is good,
> - now it ignores the active face theme color.
> - active face is darker in wireframe. almost looks like a hole in the
> mesh with all selected, (where it used to be a highlight)
> - active face is hard to see in solid view (very faint)
> 
> On Sun, May 26, 2013 at 3:42 AM, Ton Roosendaal <ton at blender.org> wrote:
>> Revision: 57023
>>          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=57023
>> Author:   ton
>> Date:     2013-05-25 17:42:20 +0000 (Sat, 25 May 2013)
>> Log Message:
>> -----------
>> Simple usability fix:
>> 
>> Mesh editmode, active face was always drawing same stipple pattern color,
>> whether face is selected or not.
>> Now it uses selection color + stipple. Looks much more consistent.
>> 
>> Modified Paths:
>> --------------
>>    trunk/blender/source/blender/editors/space_view3d/drawobject.c
>> 
>> Modified: trunk/blender/source/blender/editors/space_view3d/drawobject.c
>> ===================================================================
>> --- trunk/blender/source/blender/editors/space_view3d/drawobject.c      2013-05-25 17:28:27 UTC (rev 57022)
>> +++ trunk/blender/source/blender/editors/space_view3d/drawobject.c      2013-05-25 17:42:20 UTC (rev 57023)
>> @@ -2369,7 +2369,10 @@
>> 
>>        if (!BM_elem_flag_test(efa, BM_ELEM_HIDDEN)) {
>>                if (efa == data->efa_act) {
>> -                       glColor4ubv(data->cols[2]);
>> +                       if (BM_elem_flag_test(efa, BM_ELEM_SELECT))
>> +                               glColor4ubv(data->cols[1]);
>> +                       else
>> +                               glColor4ubv(data->cols[2]);
>>                        return DM_DRAW_OPTION_STIPPLE;
>>                }
>>                else {
>> 
>> _______________________________________________
>> Bf-blender-cvs mailing list
>> Bf-blender-cvs at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
> 
> 
> 
> -- 
> - Campbell
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers