[Bf-committers] Multiview branch, for review

Brecht Van Lommel brechtvanlommel at pandora.be
Wed Jun 12 15:13:07 CEST 2013


On Wed, Jun 12, 2013 at 1:58 AM, Dalai Felinto <dfelinto at gmail.com> wrote:
> In reply to the latest developer meeting:
>
>>> Brecht van Lommel is available next week for review.
> Brecht/others, any chance you can review the code directly from github?
>
> After I sent the patch to codereview I re-merged with trunk and on top
> of that I have some fixes that are important (FSA, thread friendly
> code). If I re-update the patch I either will have to cherry-pick the
> new commits (not the end of the world, but ... ) or the codereview
> will include the changes in trunk itself (not my code) in the blob to
> be reviewed. Please let me know.

Ok, but could you create a pull request then? It will help a lot if I
can comment on code inline. You should be able to create a pull
request to merge multiview into your own master branch where I can add
comments then.

Thanks,
Brecht.


More information about the Bf-committers mailing list