[Bf-committers] Freestyle crash

[IRIE Shinsuke]

The following patch that adds a NULL check for linestyle fixes the
crash, though I'm not sure why it becomes NULL:

Index: source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp
===================================================================
--- source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp	(revision 54129)
+++ source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp	(working copy)
@@ -665,8 +665,10 @@
 			lineset->group->id.us--;
 			lineset->group = NULL;
 		}
-		lineset->linestyle->id.us--;
-		lineset->linestyle = NULL;
+		if (lineset->linestyle) {
+			lineset->linestyle->id.us--;
+			lineset->linestyle = NULL;
+		}
 	}
 	BLI_freelistN(&srl->freestyleConfig.linesets);
 	BLI_freelistN(&srl->freestyleConfig.modules);


IRIE Shinsuke

13/01/29, IRIE Shinsuke wrote:
> Hi,
> 
> When using Freestyle build, I experienced a crash after creating a new
> scene.  You should be able to reproduce it as follows:
> 
> 1. Start Blender
> 2. Enable Freestyle and add a line set
> 3. Add new scene with "Link Objects" option
> 4. Undo (Ctrl+Z)
> Then Blender crashes immediately
> 
> Made a backtrace: http://www.pasteall.org/39233
> 
> Thanks,
> 
> r54129
> Ubuntu 12.10
>