[Bf-committers] Code Review
dfelinto at gmail.com
Fri Mar 11 19:39:22 CET 2011
This is really nice Brecht.
The system seems quite innovative. An online svn system, fantastic :)
I just sent a patch that was originally sent for blender tracker.
Let's see how it works.
I had to add it twice because my patch wasn't against the latest
latest trunk (it seems that the system can't merge if there is any
version mismatch in the files you changed).
2011/3/11 <raulf at info.upr.edu.cu>:
> Ops! I can't access to any google hosted project/site...
> Your client does not have permission to get URL / from this server.
> You are accessing this page from a forbidden country."
> So can I stick to my old way of send my patches? many times I don't have
> the possibility to choose :(
>> Hi all,
>> I'd like to do an experiment, using a code review tool for blender
>> development, to review changes before they go into trunk. My hope is
>> to improve the quality of commits, with more eyes looking at the code
>> we can prevent bugs, and I find having your code reviewed also
>> generally keeps you on your toes.
>> My intention is not to require the use of this tool, or have it used
>> for every little bugfix, it's just an experiment at this point. Some
>> * Only submit code for review if you are a developer with commit
>> rights, or if you found a developer to get your code committed. If the
>> experiment is a success, we can open it up more, but for now I'd like
>> to keep it focused on things that we know are likely to go in.
>> * Anyone can participate in the code review however.
>> * This is not a place to do big interface design discussions or
>> feature requests, stay focused on what is being worked on.
>> * If you reviewed the entire patch, and think the code is good to go
>> in, reply LGTM (looks good to me).
>> To follow code reviews, subscribe to the new bf-codereview mailing
>> list. All messages will be logged there, but comments should be added
>> in the code review tool.
>> To create a code review, create an issue at http://codereview.appspot.com:
>> * Fill in subject and description.
>> * Base URL should be Blender Trunk (the first one!), Base left empty.
>> * Add bf-codereview at blender.org to Reviewers.
>> * Attach a diff against current trunk.
>> To comment on a code review, don't reply on the list, but do it in the
>> code review tool. You can click on specific lines of code and add
>> comments inline.
>> Bf-committers mailing list
>> Bf-committers at blender.org
> Bf-committers mailing list
> Bf-committers at blender.org
More information about the Bf-committers