[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [26247] trunk/blender/source/blender: * Added #define _USE_MATH_DEFINES

[Thomas Dinges]

Hi Brecht,
sorry for the bad solution, of course you're right, we should avoid 
windows specific defines.
Thanks for fixing it properly. :)

Thomas

Am 25.01.2010 14:41, schrieb Brecht Van Lommel:
> Hi Thomas,
>
> The better solution is to add:
> #include "BLI_math.h"
>
> We should avoid having windows specific defines throughout the code.
>
> Brecht.
>
> On Mon, Jan 25, 2010 at 2:19 PM, Thomas Dinges<dingto at gmx.de>  wrote:
>    
>> Revision: 26247
>>           http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=26247
>> Author:   dingto
>> Date:     2010-01-25 14:19:52 +0100 (Mon, 25 Jan 2010)
>>
>> Log Message:
>> -----------
>> * Added #define _USE_MATH_DEFINES
>> in some files to get Blender to compile again on msvc. Without that, it didn't found M_PI.
>>
>> Modified Paths:
>> --------------
>>     trunk/blender/source/blender/blenkernel/intern/unit.c
>>     trunk/blender/source/blender/makesrna/intern/rna_brush.c
>>     trunk/blender/source/blender/makesrna/intern/rna_fcurve.c
>>
>> Modified: trunk/blender/source/blender/blenkernel/intern/unit.c
>> ===================================================================
>> --- trunk/blender/source/blender/blenkernel/intern/unit.c       2010-01-25 11:39:56 UTC (rev 26246)
>> +++ trunk/blender/source/blender/blenkernel/intern/unit.c       2010-01-25 13:19:52 UTC (rev 26247)
>> @@ -20,6 +20,7 @@
>>   *
>>   * ***** END GPL LICENSE BLOCK *****
>>   */
>> +#define _USE_MATH_DEFINES
>>
>>   #include<stdlib.h>
>>   #include<stdio.h>
>>
>> Modified: trunk/blender/source/blender/makesrna/intern/rna_brush.c
>> ===================================================================
>> --- trunk/blender/source/blender/makesrna/intern/rna_brush.c    2010-01-25 11:39:56 UTC (rev 26246)
>> +++ trunk/blender/source/blender/makesrna/intern/rna_brush.c    2010-01-25 13:19:52 UTC (rev 26247)
>> @@ -21,6 +21,7 @@
>>   *
>>   * ***** END GPL LICENSE BLOCK *****
>>   */
>> + #define _USE_MATH_DEFINES
>>
>>   #include<stdlib.h>
>>   #include<math.h>
>>
>> Modified: trunk/blender/source/blender/makesrna/intern/rna_fcurve.c
>> ===================================================================
>> --- trunk/blender/source/blender/makesrna/intern/rna_fcurve.c   2010-01-25 11:39:56 UTC (rev 26246)
>> +++ trunk/blender/source/blender/makesrna/intern/rna_fcurve.c   2010-01-25 13:19:52 UTC (rev 26247)
>> @@ -22,6 +22,8 @@
>>   * ***** END GPL LICENSE BLOCK *****
>>   */
>>
>> + #define _USE_MATH_DEFINES
>> +
>>   #include<stdlib.h>
>>   #include<math.h>
>>
>>
>>
>> _______________________________________________
>> Bf-blender-cvs mailing list
>> Bf-blender-cvs at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>>
>>
>>      
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
>