[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [26219] trunk/blender/source/blender: View3d transform was sending a too-general notifier to redraw, causing several animation editors and the property editor to redraw too, which

[Martin Poirier]

Yes, my point is that they shouldn't have done that all the time.

The properties window, for example, should only have done that if the Object tab was visible.

Having out of date data on screen is not a good solution. If redraw speed is a problem, it should then just send the notifier for all regions at the end of the operator.

Having the properties window (and possible others) out of sync after an operator is a big no no.

Martin

--- On Mon, 1/25/10, joe <joeedh at gmail.com> wrote:

> Oh and all they were doing was
> tagging their areas for a redraw.
> 
> Joe
> 
> On Mon, Jan 25, 2010 at 8:47 AM, Martin Poirier <theeth at yahoo.com>
> wrote:
> >
> >
> > --- On Sat, 1/23/10, Joseph Eagar <joeedh at gmail.com>
> wrote:
> >
> >> Received: Saturday, January 23, 2010, 11:26 PM
> >> Revision: 26219
> >>           http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=26219
> >> Author:   joeedh
> >> Date:     2010-01-24 05:26:01 +0100
> >> (Sun, 24 Jan 2010)
> >>
> >> Log Message:
> >> -----------
> >> View3d transform was sending a too-general
> notifier to
> >> redraw, causing several animation editors and the
> property
> >> editor to redraw too, which can really slow
> things
> >> down.  added a more specific ND_VIEW3D_TRANSFORM
> >> notifier to solve this.
> >
> > That is incorrect.
> >
> > At least for the properties window, this change means
> the position/rotation/size properties are not redrawn
> properly when modified.
> >
> > Maybe the problem is that those other windows were
> reacting incorrectly to the notifier, in a too generic
> fashion.
> >
> > Martin
> >
> >
> >    
>  __________________________________________________________________
> > Looking for the perfect gift? Give the gift of
> Flickr!
> >
> > http://www.flickr.com/gift/
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-committers
> >
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
> 


      __________________________________________________________________
The new Internet Explorer® 8 - Faster, safer, easier.  Optimized for Yahoo!  Get it Now for Free! at http://downloads.yahoo.com/ca/internetexplorer/