[Bf-committers] [Bf-blender-cvs] SVN commit 23133

[Thomas Dinges]

Hey,
i just found that Billrey reverted the Recent File Bugfix from Brecht 
(commit 23082) in his "Make Hotkeys Apple only" Commit 23090. I 
recommitet that.

Billrey you also made modifications in line 556:

-uiBlockSetHandleFunc(block, redo_cb, arg_op);
+uiBlockSetFunc(block, redo_cb, arg_op, NULL);

and Line 534
-static void redo_cb(bContext *C, void *arg_op, int event)
+static void redo_cb(bContext *C, void *arg_op, void *arg2)

Was that on purpose? Or an accident too? If it was on purpose please 
note that in the commit log!

It would be great if everybody would update his/her SVN before 
commiting, so we don't get such problems anymore.
Thanks

Thomas

Thomas Dinges schrieb:
> Revision: 23133
>           http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=23133
> Author:   dingto
> Date:     2009-09-11 23:02:31 +0200 (Fri, 11 Sep 2009)
>
> Log Message:
> -----------
> 2.5
> Revert some changes from commit 23090. Make sure you update SVN before you commit!! 
>
> Modified Paths:
> --------------
>     branches/blender2.5/blender/source/blender/windowmanager/intern/wm_operators.c
>
> Modified: branches/blender2.5/blender/source/blender/windowmanager/intern/wm_operators.c
> ===================================================================
> --- branches/blender2.5/blender/source/blender/windowmanager/intern/wm_operators.c	2009-09-11 20:06:09 UTC (rev 23132)
> +++ branches/blender2.5/blender/source/blender/windowmanager/intern/wm_operators.c	2009-09-11 21:02:31 UTC (rev 23133)
> @@ -803,7 +803,7 @@
>  			WM_read_file(C, G.sce, op->reports);
>  		}
>  		else {
> -			struct RecentFile *recent = BLI_findlink(&(G.recent_files), event-2);
> +			struct RecentFile *recent = BLI_findlink(&(G.recent_files), event-1);
>  			if(recent) {
>  				WM_event_add_notifier(C, NC_WINDOW, NULL);
>  				WM_read_file(C, recent->filename, op->reports);
> @@ -831,11 +831,11 @@
>  	EnumPropertyItem tmp = {0, "", 0, "", ""};
>  	EnumPropertyItem *item= NULL;
>  	struct RecentFile *recent;
> -	int totitem= 0, i, ofs= 0;
> +	int totitem= 0, i;
>  
>  	/* dynamically construct enum */
>  	for(recent = G.recent_files.first, i=0; (i<U.recent_files) && (recent); recent = recent->next, i++) {
> -		tmp.value= i+ofs+1;
> +		tmp.value= i+1;
>  		tmp.identifier= recent->filename;
>  		tmp.name= BLI_short_filename(recent->filename);
>  		RNA_enum_item_add(&item, &totitem, &tmp);
>
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>
>