[Bf-committers] [PATCH] use ADD_SUBDIRECTORY() instead of SUBDIRS() in the cmake files
neundorf at kde.org
Thu Apr 23 21:55:27 CEST 2009
On Monday 20 April 2009, Alexander Neundorf wrote:
> On Thursday 16 April 2009, Alexander Neundorf wrote:
> > Hi,
> > I just had a look at the cmake files in blender and noticed that you are
> > using the SUBDIRS() command instead of ADD_SUBDIRECTORY.
> > The main difference between the two is that ADD_SUBDIRECTORY() is
> > processed immediately, while the directories added with SUBDIRS() are
> > processed after everything else in the CMakeLists.txt has been processed.
> > This is usually not what one would expect, so using ADD_SUBDIRECTORY() is
> > usually better. The attached patch does that.
> > Please apply if you think it makes sense.
> Let's see whether the attachement gets through this time...
Any comments on the patch ?
Using add_subdirectory() does really behave much more as expected than
subdirs() does, so I really recommend switching to add_subdirectory.
More information about the Bf-committers