[Bf-committers] [bf-blender-Patches][6842] A new procedural texture implementation to generate tiling patterns
Ahmad Kabani
ahmadkabani at yahoo.com
Fri Nov 9 20:08:50 CET 2007
Ah. I was a bit quick to reply there! My original question still stands. The subversion number doesn't seem to be stored in the blend file when I do a save (it comes back as 0). So the following check still passes for files I save with current patch:
if (main->versionfile < 245 || (main->versionfile == 245 && main->subversionfile < 4))
and it resets the parameters to default.
Ahmad
----- Original Message ----
From: Ahmad Kabani <ahmadkabani at yahoo.com>
To: bf-blender developers <bf-committers at blender.org>
Sent: Friday, November 9, 2007 1:26:34 PM
Subject: Re: [Bf-committers] [bf-blender-Patches][6842] A new procedural texture implementation to generate tiling patterns
Thanks Martin. Will do.
----- Original Message ----
From: Martin Poirier <theeth at yahoo.com>
To: bf-blender developers <bf-committers at blender.org>
Sent: Friday, November 9, 2007 12:30:13 PM
Subject: Re: [Bf-committers] [bf-blender-Patches][6842] A new procedural texture implementation to generate tiling patterns
--- Ahmad Kabani <ahmadkabani at yahoo.com> wrote:
> I'm not familiar with how subversion levels work. Do
> you normally revert it to 0 after a release? It
> didn't seem like it since it is now at 7 in latest
> SVN checkout. I may have missed it while away from
> the source code for a while.
Yes, subversion is reset to 0 each release. It's
something that's used inter-releases, basically.
> For now, I'll use (main->versionfile < 245) and
> notify users that appending from files of older
> versions may not work correctly (which it is
> anyway).
You could also do:
if (main->versionfile < 245 || (main->versionfile ==
245 && main->subversionfile < 4))
Always correct older versions and correct 2.45
versions when subversion is lower than the one where
your feature was introduced.
> Will someone automatically fix do_versions() if the
> patch is integrated into blender OR is that my
> responsibility to provide as part of the patch?
Hopefully, the patch integrator will fix it if it
doesn't work correctly (you can add a comment to that
effect in the tracker or in the code, to make sure
it's checked).
Martin
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
_______________________________________________
Bf-committers mailing list
Bf-committers at blender.org
http://lists.blender.org/mailman/listinfo/bf-committers
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
_______________________________________________
Bf-committers mailing list
Bf-committers at blender.org
http://lists.blender.org/mailman/listinfo/bf-committers
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
More information about the Bf-committers
mailing list