[Bf-committers] Re: Bug fix , vertex group name too long cause bad selection in Vertex Groups Panel

[Ton Roosendaal]

Hi,

Sorry dude, the amount of patches waiting for review is far more than  
people reviewing it! :)
I know it is frustrating, i'd prefer to have more time for that too,  
but really put work for the orange movie at #1 now. Anyone else maybe?

-Ton-

On 31 Jan, 2006, at 17:08, bmx007 wrote:

> Will my patch be commited or have i not follow the regular process ?
> Thanx
>
>
> On 1/27/06, bmx007 <bmx007 at gmail.com > wrote:hello, (this is my first  
> patch, so i don't know how to proceed in submitting patch)
>> here is a patch correct a bug i found. It appears when you create  
>> more than 10 groups with long name
>> 31 char ... ( the snprintf truncate the menu separator ( %xN ) )
>>
>>
>> Index: buttons_editing.c
>> ===================================================================
>> RCS file:  
>> /cvsroot/bf-blender/blender/source/blender/src/buttons_editing.c,v
>> retrieving revision 1.240
>>  diff - r1.240 buttons_editing.c
>> 3277c3277
>> <       char (*qsort_ptr)[32] = NULL;
>> ---
>> >       char (*qsort_ptr)[sizeof(dg->name)+5] = NULL; // +5 for  
>> "%x99|"
>> 3278a3279
>> >       int printed;
>>  3293,3294c3294,3296
>> <                       snprintf (qsort_ptr[index - 1], sizeof  
>> (qsort_ptr[0]),
>> <                                         "%s%%x%d|", dg->name,  
>> index);
>> ---
>> >                       printed = snprintf (qsort_ptr[index - 1],  
>> sizeof (dg->name), dg->name);
>> >                       snprintf (qsort_ptr[index - 1]+printed, +5+1,  
>> "%%x%d|", index);
>> >                       // +1 to move the \0
>> 3301c3303
>> <       s= menustr = MEM_callocN((32 * defCount)+30,  
>> "menustr");        // plus 30 for when defCount==0
>> ---
>> >       s= menustr = MEM_callocN((sizeof(qsort_ptr[0]) *  
>> defCount)+30, "menustr");      // plus 30 for when defCount==0
>>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
>
------------------------------------------------------------------------ 
--
Ton Roosendaal  Blender Foundation ton at blender.org  
http://www.blender.org