[Bf-committers] Compile warnings
Brecht Van Lommel
brechtvanlommel at pandora.be
Fri Sep 16 02:44:47 CEST 2005
This is sort of my fault. I'll clean the code up and check on do a better
review of it...
> Ton Roosendaal wrote:
>> - ImagePaint
>> The code added in headerimage.c is very messy. At least follow a bit
>> the C convention as used in the rest of the file. Further I don't
>> advise to use the old clever_numbut code anymore...
>> then there's a global array written with capitals (UVTEXTTOOL_DATA),
>> and I really don't get why all these globals are needed in
>> In space.c you use calls from imagepaint.c without prototypes.
>> This could have used a good code review before added, and poking
>> people who like to design button panels. Seems like much wanted
>> functionality yes, but worth checking on a good integration to make
>> it future proof. :)
> Hi ton,
> totally argree,
> This is why put 2D UV painting ( aka imagepaint )to patch tracker first.
> I even pointed out some weak points you're complaining about now.
> Especially global vars.
> But i never got any usefull feedback on how to do it better.
> Asking brecht (don't want to blame him at all) resulted in 'commit and
> see' so .. i don't mind to roll back the whole thing and do it right.
> Only i don't have a faint idea what is supposed to be *right*.
> /* beeing scientist and C++ coder who likes standard template libs
> (STL) makes me quilty 'per se' and i apologize for that. */
> about headerimage.c
> is the *mess* declaring local vars ? ( easy to fix )
> about use of clever_numbut code .. never really liked it .. but how to
> get 'user input' for some numbers needed for creation process (
> preferably remembering last input ) ...
> and so on
> hmm .. but if someone would have looked at the patch ..
> .. sigh ..
More information about the Bf-committers