[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/render/intern/source envmap.c

Martin Poirier theeth at yahoo.com
Sat Jun 4 02:29:45 CEST 2005


--- Ton Roosendaal <ton at blender.org> wrote:

> ton (Ton Roosendaal) 2005/06/03 20:44:01 CEST
> 
>   Modified files:
>     blender/source/blender/render/intern/source
> envmap.c 
>   
>   Log:
>   Added threadsafe patch from Martin.
>   Now envmaps of type "Load" should not give errors.
> I assume Martin tested!

It rendered ok (used a file that rendered sloow, so
scanline thread would get a good chance to switch
context). Only used a single processor to test, but
loading memory from disk usually causes a
thread/process context change, so it would have
affected single processors too.

To test throroughly, I would have needed to do a full
memory check, since the unthread safeness there would
have caused a memory leak (image buffer loaded in both
thread at once) but would still have rendered
correctly.

Same goes for testing the image testure loading mutex.

Martin


		
__________________________________ 
Do you Yahoo!? 
Read only the mail you want - Yahoo! Mail SpamGuard. 
http://promotions.yahoo.com/new_mail 


More information about the Bf-committers mailing list