[Bf-committers] Re: [Bf-blender-cvs] CVS commit: blender/source/blender/include BIF_editmesh.h blender/source/blender/src drawobject.c editmesh_mods.c editsima.c editview.c

[Daniel Dunbar]

Bah!

Would work as an excuse if it was going to be removed anytime soon....

--- Ton Roosendaal <ton at blender.org> wrote:

> Hi,
> 
> >   And from the "Dear lazy programmers" file: After you have extern  
> > declared
> >   a variable 5 or more times at the top a function, you would have  
> > actually
> >   saved a lot of effort by just putting it in the header where it  
> > belonged.
> >   Or perhaps you thought by hiding it no one else would notice you were
> >   using global variables to pass information around. Tsk tsk.
> 
> In contrary, I prefer to have them in the top of the function as signal  
> that this is bad code. Putting them in the header file will make it  
> sorta legal. :)
> These globals were supposed to be removed, that's the lazy part!
> 
> -Ton-
> 
> 
> >
> >   Revision  Changes    Path
> >   1.39      +3 -2      blender/source/blender/include/BIF_editmesh.h
> >      
> > <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/ 
> > blender/include/BIF_editmesh.h.diff?r1=1.38&r2=1.39&cvsroot=bf- 
> > blender>
> >   1.199     +1 -2      blender/source/blender/src/drawobject.c
> >      
> > <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/ 
> > blender/src/drawobject.c.diff?r1=1.198&r2=1.199&cvsroot=bf-blender>
> >   1.55      +7 -6      blender/source/blender/src/editmesh_mods.c
> >      
> > <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/ 
> > blender/src/editmesh_mods.c.diff?r1=1.54&r2=1.55&cvsroot=bf-blender>
> >   1.35      +5 -4      blender/source/blender/src/editsima.c
> >      
> > <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/ 
> > blender/src/editsima.c.diff?r1=1.34&r2=1.35&cvsroot=bf-blender>
> >   1.66      +3 -6      blender/source/blender/src/editview.c
> >      
> > <http://projects.blender.org/viewcvs/viewcvs.cgi/blender/source/ 
> > blender/src/editview.c.diff?r1=1.65&r2=1.66&cvsroot=bf-blender>
> > _______________________________________________
> > Bf-blender-cvs mailing list
> > Bf-blender-cvs at projects.blender.org
> > http://projects.blender.org/mailman/listinfo/bf-blender-cvs
> >
> >
> ------------------------------------------------------------------------ 
> --
> Ton Roosendaal  Blender Foundation ton at blender.org  
> http://www.blender.org
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at projects.blender.org
> http://projects.blender.org/mailman/listinfo/bf-committers
> 


daniel dunbar