It might be a "Off by one" bug less noticeable in the non tiled pipeline.<br><br><div class="gmail_quote">2012/1/16 <span dir="ltr"><<a href="mailto:dfelinto@gmail.com">dfelinto@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Reviewers: <a href="http://bf-codereview_blender.org" target="_blank">bf-codereview_blender.org</a>, jbkkavt,<br>
<br>
Description:<br>
I had to make it into a Complex node to allow the readEWA to be used.<br>
(the other alternative is to expose readEWA to all node types when dx<br>
and dy are passed as parameter to read).<br>
<br>
The result is almost perfect (comparing to trunk). The only problem is a<br>
glitch in the middle:<br>
<br>
trunk: <a href="http://www.pasteall.org/pic/show.php?id=24506" target="_blank">http://www.pasteall.org/pic/show.php?id=24506</a><br>
tile: <a href="http://www.pasteall.org/pic/show.php?id=24505" target="_blank">http://www.pasteall.org/pic/show.php?id=24505</a><br>
<br>
I'm yet to investigate the reason. It may be the readEWA code (which is<br>
also used by the MapUV node, but works fine there).<br>
<br>
Please review this at <a href="http://codereview.appspot.com/5528108/" target="_blank">http://codereview.appspot.com/5528108/</a><br>
<br>
Affected files:<br>
source/blender/compositor/CMakeLists.txt<br>
source/blender/compositor/intern/COM_Converter.cpp<br>
source/blender/compositor/nodes/COM_DisplaceNode.cpp<br>
source/blender/compositor/nodes/COM_DisplaceNode.h<br>
source/blender/compositor/operations/COM_DisplaceOperation.cpp<br>
source/blender/compositor/operations/COM_DisplaceOperation.h<br>
<br>
<br>
_______________________________________________<br>
Bf-codereview mailing list<br>
<a href="mailto:Bf-codereview@blender.org">Bf-codereview@blender.org</a><br>
<a href="http://lists.blender.org/mailman/listinfo/bf-codereview" target="_blank">http://lists.blender.org/mailman/listinfo/bf-codereview</a><br>
</blockquote></div><br>