Would Double Edge Mask be better?<div><br></div><div>Daniel Salazar<br>3Developer.com<br>
<br><br><div class="gmail_quote">On Fri, Jan 6, 2012 at 11:15 AM, <span dir="ltr"><<a href="mailto:brechtvanlommel@gmail.com">brechtvanlommel@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Regarding the name of the node, it's a bit strange that this one is also<br>
called Matte while it doesn't create a matte necessarily, it's sort of<br>
blending two masks? Is there a standard name for this type of operation<br>
in other software?<br>
<br>
<br>
<a href="http://codereview.appspot.com/5523046/diff/1/source/blender/makesrna/intern/rna_nodetree.c" target="_blank">http://codereview.appspot.com/<u></u>5523046/diff/1/source/blender/<u></u>makesrna/intern/rna_nodetree.c</a><br>
File source/blender/makesrna/<u></u>intern/rna_nodetree.c (right):<br>
<br>
<a href="http://codereview.appspot.com/5523046/diff/1/source/blender/makesrna/intern/rna_nodetree.c#newcode2134" target="_blank">http://codereview.appspot.com/<u></u>5523046/diff/1/source/blender/<u></u>makesrna/intern/rna_nodetree.<u></u>c#newcode2134</a><br>
source/blender/makesrna/<u></u>intern/rna_nodetree.c:2134: {1, "ADJONL", 0,<br>
"Adjacent Only", "Only inner mask pixels adjacent to outer mask pixels<br>
are considerer during mask calculation"},<br>
This name does not need to be abbreviated, use ADJACENTE_ONLY, maybe<br>
above BLEED_OUT and KEEP_IN as well.<br>
<br>
Typo: considerer => considered<br>
<br>
<a href="http://codereview.appspot.com/5523046/diff/1/source/blender/makesrna/intern/rna_nodetree_types.h" target="_blank">http://codereview.appspot.com/<u></u>5523046/diff/1/source/blender/<u></u>makesrna/intern/rna_nodetree_<u></u>types.h</a><br>
File source/blender/makesrna/<u></u>intern/rna_nodetree_types.h (right):<br>
<br>
<a href="http://codereview.appspot.com/5523046/diff/1/source/blender/makesrna/intern/rna_nodetree_types.h#newcode132" target="_blank">http://codereview.appspot.com/<u></u>5523046/diff/1/source/blender/<u></u>makesrna/intern/rna_nodetree_<u></u>types.h#newcode132</a><br>
source/blender/makesrna/<u></u>intern/rna_nodetree_types.h:<u></u>132: DefNode(<br>
CompositorNode, CMP_NODE_DBLEDGMATTE, def_cmp_dbl_edg_matte,<br>
"DBLEDGMATTE", DblEdgMatte, "Double Edge Matte", ""<br>
)<br>
Same here, don't use DBLEDGMATTE abbreviation.<br>
<br>
<a href="http://codereview.appspot.com/5523046/diff/1/source/blender/nodes/composite/nodes/node_composite_dblEdgMatte.c" target="_blank">http://codereview.appspot.com/<u></u>5523046/diff/1/source/blender/<u></u>nodes/composite/nodes/node_<u></u>composite_dblEdgMatte.c</a><br>
File source/blender/nodes/<u></u>composite/nodes/node_<u></u>composite_dblEdgMatte.c<br>
(right):<br>
<br>
<a href="http://codereview.appspot.com/5523046/diff/1/source/blender/nodes/composite/nodes/node_composite_dblEdgMatte.c#newcode43" target="_blank">http://codereview.appspot.com/<u></u>5523046/diff/1/source/blender/<u></u>nodes/composite/nodes/node_<u></u>composite_dblEdgMatte.c#<u></u>newcode43</a><br>
source/blender/nodes/<u></u>composite/nodes/node_<u></u>composite_dblEdgMatte.c:43: {<br>
SOCK_FLOAT, 0, "D.E.M. Mask"}, // output socket definition<br>
Just call output "Mask".<br>
<br>
<a href="http://codereview.appspot.com/5523046/diff/1/source/blender/nodes/composite/nodes/node_composite_dblEdgMatte.c#newcode47" target="_blank">http://codereview.appspot.com/<u></u>5523046/diff/1/source/blender/<u></u>nodes/composite/nodes/node_<u></u>composite_dblEdgMatte.c#<u></u>newcode47</a><br>
source/blender/nodes/<u></u>composite/nodes/node_<u></u>composite_dblEdgMatte.c:47:<br>
static void node_composit_exec_<u></u>dbledgmatte(void *UNUSED(data), bNode<br>
*node, bNodeStack **in, bNodeStack **out) {<br>
It might be nice to split this up into smaller pieces, 900 lines is a<br>
lot for one function..<br>
<br>
<a href="http://codereview.appspot.com/5523046/" target="_blank">http://codereview.appspot.com/<u></u>5523046/</a><br>
</blockquote></div><br></div>