[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [53521] trunk/blender/source/blender/bmesh /intern/bmesh_construct.c: fix [#33689] Crash with decimate modifier

[Campbell Barton]

Revision: 53521
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=53521
Author:   campbellbarton
Date:     2013-01-03 07:53:30 +0000 (Thu, 03 Jan 2013)
Log Message:
-----------
fix [#33689] Crash with decimate modifier

in fact a more general bug in BM_face_create_ngon() where edges containing the same vertex multiple times were not accounted for.

Modified Paths:
--------------
    trunk/blender/source/blender/bmesh/intern/bmesh_construct.c

Modified: trunk/blender/source/blender/bmesh/intern/bmesh_construct.c
===================================================================
--- trunk/blender/source/blender/bmesh/intern/bmesh_construct.c	2013-01-03 07:36:48 UTC (rev 53520)
+++ trunk/blender/source/blender/bmesh/intern/bmesh_construct.c	2013-01-03 07:53:30 UTC (rev 53521)
@@ -215,6 +215,11 @@
 	do {
 		BMEdge *e2 = e;
 
+		/* vertex array is (len + 1) */
+		if (UNLIKELY(v_index > len)) {
+			goto err; /* vertex in loop twice */
+		}
+
 		verts[v_index++] = v;
 		edges2[e2_index++] = e;