[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [43164] branches/bmesh/blender/source/ blender/modifiers/intern: remove re-tesselation after constrictive modifiers, this way we can avoid calculating tessfaces between multiple constructive modifiers to speedup the modifier stack .

Campbell Barton ideasman42 at gmail.com
Thu Jan 5 13:50:31 CET 2012


Revision: 43164
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=43164
Author:   campbellbarton
Date:     2012-01-05 12:50:23 +0000 (Thu, 05 Jan 2012)
Log Message:
-----------
remove re-tesselation after constrictive modifiers, this way we can avoid calculating tessfaces between multiple constructive modifiers to speedup the modifier stack.

Modified Paths:
--------------
    branches/bmesh/blender/source/blender/modifiers/intern/MOD_mask.c
    branches/bmesh/blender/source/blender/modifiers/intern/MOD_mirror.c
    branches/bmesh/blender/source/blender/modifiers/intern/MOD_screw.c
    branches/bmesh/blender/source/blender/modifiers/intern/MOD_solidify.c

Modified: branches/bmesh/blender/source/blender/modifiers/intern/MOD_mask.c
===================================================================
--- branches/bmesh/blender/source/blender/modifiers/intern/MOD_mask.c	2012-01-05 12:40:09 UTC (rev 43163)
+++ branches/bmesh/blender/source/blender/modifiers/intern/MOD_mask.c	2012-01-05 12:50:23 UTC (rev 43164)
@@ -399,10 +399,8 @@
 	BLI_ghashIterator_free(hashIter);
 
 	MEM_freeN(loop_mapping);
-	
-	/* BMESH_TODO - remove this and make modifiers create their own tessfaces on demand */
-	CDDM_recalc_tesselation(result);
 
+	/* why is this needed? - campbell */
 	/* recalculate normals */
 	CDDM_calc_normals(result);
 	

Modified: branches/bmesh/blender/source/blender/modifiers/intern/MOD_mirror.c
===================================================================
--- branches/bmesh/blender/source/blender/modifiers/intern/MOD_mirror.c	2012-01-05 12:40:09 UTC (rev 43163)
+++ branches/bmesh/blender/source/blender/modifiers/intern/MOD_mirror.c	2012-01-05 12:50:23 UTC (rev 43164)
@@ -283,9 +283,6 @@
 		MEM_freeN(vtargetmap);
 	}
 
-	/* BMESH_TODO - remove this and make modifiers create their own tessfaces on demand */
-	CDDM_recalc_tesselation(result);
-
 	return result;
 }
 

Modified: branches/bmesh/blender/source/blender/modifiers/intern/MOD_screw.c
===================================================================
--- branches/bmesh/blender/source/blender/modifiers/intern/MOD_screw.c	2012-01-05 12:40:09 UTC (rev 43163)
+++ branches/bmesh/blender/source/blender/modifiers/intern/MOD_screw.c	2012-01-05 12:50:23 UTC (rev 43164)
@@ -904,11 +904,8 @@
 	}
 #endif
 
-
-	/* BMESH_TODO - remove this and make modifiers create their own tessfaces on demand */
-	CDDM_recalc_tesselation(result);
-
 	if((ltmd->flag & MOD_SCREW_NORMAL_CALC) == 0) {
+		/* BMESH_TODO, we only need to get vertex normals here, this is way overkill */
 		CDDM_calc_normals(result);
 	}
 

Modified: branches/bmesh/blender/source/blender/modifiers/intern/MOD_solidify.c
===================================================================
--- branches/bmesh/blender/source/blender/modifiers/intern/MOD_solidify.c	2012-01-05 12:40:09 UTC (rev 43163)
+++ branches/bmesh/blender/source/blender/modifiers/intern/MOD_solidify.c	2012-01-05 12:50:23 UTC (rev 43164)
@@ -728,9 +728,6 @@
 		/* BMESH_TODO, we only need to get vertex normals here, this is way overkill */
 		CDDM_calc_normals(result);
 	}
-	else {
-		CDDM_recalc_tesselation(result);
-	}
 	
 	if (dm != odm) {
 		dm->needsFree = 1;



More information about the Bf-blender-cvs mailing list