[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [43086] trunk/blender/source/blender/ editors/animation/anim_ipo_utils.c: Bugfix [#29629] UV animation stops working forever if Edit mode entered

Joshua Leung aligorith at gmail.com
Tue Jan 3 03:11:22 CET 2012


Revision: 43086
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=43086
Author:   aligorith
Date:     2012-01-03 02:11:11 +0000 (Tue, 03 Jan 2012)
Log Message:
-----------
Bugfix [#29629] UV animation stops working forever if Edit mode entered
Thanks Sergey for the patch!

This bug, and many like it would arise because at some point a F-Curve would get
detected as being unable to be resolved (when trying to display its name in an
Animation Editor), so gets tagged as being "disabled". It was assumed that such
channels usually belonged to deleted data or stuff that wouldn't be able to be
resolved again for a long time. However, in cases like UV settings, they may
only be unavailable temporarily.

As a compromise, this patch clears this disabled flag if a channel is found to
be now working when (in the process of finding out its name when redrawing an
Animation Editor) it can be resolved, in the same place where the disabling was
taking place. This doesn't work fullproof in tests I've done, but should be
nicer than before.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/animation/anim_ipo_utils.c

Modified: trunk/blender/source/blender/editors/animation/anim_ipo_utils.c
===================================================================
--- trunk/blender/source/blender/editors/animation/anim_ipo_utils.c	2012-01-02 19:44:13 UTC (rev 43085)
+++ trunk/blender/source/blender/editors/animation/anim_ipo_utils.c	2012-01-03 02:11:11 UTC (rev 43086)
@@ -161,6 +161,11 @@
 			 *	use the struct's icon if it is set
 			 */
 			icon= RNA_struct_ui_icon(ptr.type);
+			
+			/* valid path - remove the invalid tag since we now know how to use it saving
+			 * users manual effort to reenable using "Revive Disabled FCurves" [#29629]
+			 */
+			fcu->flag &= ~FCURVE_DISABLED;
 		}
 		else {
 			/* invalid path */



More information about the Bf-blender-cvs mailing list