[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [23932] trunk/blender/source/blender/ editors/animation/anim_channels_defines.c: Removed some obsolete comments left in previous commit

Joshua Leung aligorith at gmail.com
Mon Oct 19 04:23:34 CEST 2009


Revision: 23932
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=23932
Author:   aligorith
Date:     2009-10-19 04:23:34 +0200 (Mon, 19 Oct 2009)

Log Message:
-----------
Removed some obsolete comments left in previous commit

Modified Paths:
--------------
    trunk/blender/source/blender/editors/animation/anim_channels_defines.c

Modified: trunk/blender/source/blender/editors/animation/anim_channels_defines.c
===================================================================
--- trunk/blender/source/blender/editors/animation/anim_channels_defines.c	2009-10-19 02:17:57 UTC (rev 23931)
+++ trunk/blender/source/blender/editors/animation/anim_channels_defines.c	2009-10-19 02:23:34 UTC (rev 23932)
@@ -2298,12 +2298,14 @@
 	
 	/* find the channel that got changed */
 	for (ale= anim_data.first; ale; ale= ale->next) {
-		/* compare data, type, and owner/id info */
+		/* compare data, and type as main way of identifying the channel */
 		if ((ale->data == ale_setting->data) && (ale->type == ale_setting->type)) {
-			//if (ale->id == ale_setting->id) {
+			/* we also have to check the ID, this is assigned to, since a block may have multiple users */
+			// TODO: is the owner-data more revealing?
+			if (ale->id == ale_setting->id) {
 				match= ale;
 				break;
-			//}
+			}
 		}
 	}
 	if (match == NULL) {
@@ -2567,11 +2569,10 @@
 		}
 		
 		/* set call to send relevant notifiers and/or perform type-specific updates */
-		// TODO: for 'visible' toggles, use the 'N' version of this, storing a duplicate copy of the ale that this uses
 		if (but) {
 			/* 'visibility' toggles for Graph Editor need special flushing */
 			if (setting == ACHANNEL_SETTING_VISIBLE) 
-				uiButSetNFunc(but, achannel_setting_visible_widget_cb, MEM_dupallocN(ale), /*SET_INT_IN_POINTER(...)*/0);
+				uiButSetNFunc(but, achannel_setting_visible_widget_cb, MEM_dupallocN(ale), 0);
 			else
 				uiButSetFunc(but, achannel_setting_widget_cb, NULL, NULL);
 		}





More information about the Bf-blender-cvs mailing list