[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [17019] trunk/blender: Fix for bug #17793: the glFinish() call in ghost that was disabled in a previous commit, because it was causing performance issues for the game engine, apparently still is needed to solved issues with FSAA.

[Brecht Van Lommel]

Revision: 17019
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=17019
Author:   blendix
Date:     2008-10-11 18:03:17 +0200 (Sat, 11 Oct 2008)

Log Message:
-----------
Fix for bug #17793: the glFinish() call in ghost that was disabled in a previous commit, because it was causing performance issues for the game engine, apparently still is needed to solved issues with FSAA. Now instead it will still call this for blender but not anymore for blenderplayer.

Modified Paths:
--------------
    trunk/blender/intern/ghost/intern/GHOST_WindowWin32.cpp
    trunk/blender/source/blender/src/ghostwinlay.c

Modified: trunk/blender/intern/ghost/intern/GHOST_WindowWin32.cpp
===================================================================
--- trunk/blender/intern/ghost/intern/GHOST_WindowWin32.cpp	2008-10-11 15:55:22 UTC (rev 17018)
+++ trunk/blender/intern/ghost/intern/GHOST_WindowWin32.cpp	2008-10-11 16:03:17 UTC (rev 17019)
@@ -434,16 +434,6 @@
 
 GHOST_TSuccess GHOST_WindowWin32::swapBuffers()
 {
-	// adding a glFinish() here is to prevent Geforce in 'full scene antialias' mode
-	// from antialising the Blender window. Officially a swapbuffers does a glFinish
-	// itself, so this feels really like a hack... but it won't harm. (ton)
-	// 
-	// disabled this because it is a performance killer for the game engine, glFinish
-	// forces synchronization with the graphics card and calling it is strongly
-	// discouraged for good performance. (brecht)
-	//
-	// glFinish();
-
 	return ::SwapBuffers(m_hDC) == TRUE ? GHOST_kSuccess : GHOST_kFailure;
 }
 

Modified: trunk/blender/source/blender/src/ghostwinlay.c
===================================================================
--- trunk/blender/source/blender/src/ghostwinlay.c	2008-10-11 15:55:22 UTC (rev 17018)
+++ trunk/blender/source/blender/src/ghostwinlay.c	2008-10-11 16:03:17 UTC (rev 17019)
@@ -478,6 +478,16 @@
 }
 
 void window_swap_buffers(Window *win) {
+	// adding a glFinish() here is to prevent Geforce in 'full scene antialias' mode
+	// from antialising the Blender window. Officially a swapbuffers does a glFinish
+	// itself, so this feels really like a hack... but it won't harm. (ton)
+	// 
+	// moved it here from ghost because it is a performance killer for the game engine,
+	// glFinish forces synchronization with the graphics card and calling it is strongly
+	// discouraged for good performance. (brecht)
+	//
+	glFinish();
+
 	GHOST_SwapWindowBuffers(win->ghostwin);
 }